Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet-core: Add filter_map function to filter owned notes #2132

Merged
merged 1 commit into from
Aug 14, 2024
Merged

wallet-core: Add filter_map function to filter owned notes #2132

merged 1 commit into from
Aug 14, 2024

Conversation

moCello
Copy link
Member

@moCello moCello commented Aug 14, 2024

Resolves #2129

@moCello moCello force-pushed the mocello/2129_wallet_filter_map branch 4 times, most recently from 45bea1a to 0498499 Compare August 14, 2024 15:13
ZER0
ZER0 requested changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@ZER0 ZER0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rfc only for the filter_map name to be honest, but if you want to apply also the single-line function would be nice. But those comments are not mandatory.

wallet-core/src/keys.rs Outdated Show resolved Hide resolved
wallet-core/src/lib.rs Outdated Show resolved Hide resolved
wallet-core/src/lib.rs Outdated Show resolved Hide resolved
@moCello moCello force-pushed the mocello/2129_wallet_filter_map branch from 0498499 to ba594e6 Compare August 14, 2024 16:32
ZER0
ZER0 approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@ZER0 ZER0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moCello moCello requested a review from ZER0 August 14, 2024 16:33
ZER0
ZER0 approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@ZER0 ZER0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I, Matteo, approve this content.
For the second time.
Because a misclick.

@moCello moCello merged commit 72f2427 into master Aug 14, 2024
8 checks passed
@moCello moCello deleted the mocello/2129_wallet_filter_map branch August 14, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZER0 ZER0 ZER0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wallet-core: add a "filter map" function(s) for set of Phoenix notes
2 participants
@moCello @ZER0