Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet-core: Add function to sum the balance for phoenix notes #2119

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

moCello
Copy link
Member

@moCello moCello commented Aug 13, 2024

Resolves #2117

@moCello moCello force-pushed the mocello/2117_wallet_balance branch from 7b50103 to 9520b98 Compare August 13, 2024 15:04
Copy link
Contributor

@ZER0 ZER0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks solid, but there are a few comments that need to be addressed or clarified with a rationale.

wallet-core/src/lib.rs Outdated Show resolved Hide resolved
wallet-core/src/profile.rs Outdated Show resolved Hide resolved
wallet-core/src/profile.rs Outdated Show resolved Hide resolved
@moCello moCello force-pushed the mocello/2117_wallet_balance branch 2 times, most recently from 9e00cd3 to 93311a2 Compare August 14, 2024 10:25
@moCello moCello force-pushed the mocello/2117_wallet_balance branch from 93311a2 to 4a05f66 Compare August 14, 2024 10:45
@moCello moCello requested a review from ZER0 August 14, 2024 11:15
Copy link
Contributor

@ZER0 ZER0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moCello moCello merged commit 0bb889e into master Aug 14, 2024
8 checks passed
@moCello moCello deleted the mocello/2117_wallet_balance branch August 14, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wallet-core: calculate the balance from a given set of notes
2 participants