Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web-wallet: Add DashboardMenu component #2103

Merged
merged 1 commit into from
Aug 14, 2024
Merged

web-wallet: Add DashboardMenu component #2103

merged 1 commit into from
Aug 14, 2024

Conversation

kieranhall
Copy link
Member

Resolves #2074

@kieranhall kieranhall self-assigned this Aug 11, 2024
@kieranhall kieranhall force-pushed the feature-2074 branch 3 times, most recently from 153cb66 to b6baead Compare August 14, 2024 08:59
@kieranhall kieranhall marked this pull request as ready for review August 14, 2024 09:00
@kieranhall kieranhall force-pushed the feature-2074 branch 4 times, most recently from 79bd235 to ada59af Compare August 14, 2024 09:31
@nortonandreev
Copy link
Contributor

Just wanted to confirm we want to go with anchors instead of buttons, ie. that each functionality will go under its own path?

A minor detail – In the design, the icons appear black, whereas in the implementation they are using the anchor color.

Screenshot 2024-08-14 at 15 45 45 Screenshot 2024-08-14 at 15 45 36

@kieranhall
Copy link
Member Author

Just wanted to confirm we want to go with anchors instead of buttons, ie. that each functionality will go under its own path?

Yeah, the navigation will take you to a new route. This is covered in issue #2075 which can be worked on after this is merged.

A minor detail – In the design, the icons appear black, whereas in the implementation they are using the anchor color.

Good catch, I will override this in the component styles.

Copy link
Contributor

@nortonandreev nortonandreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

@kieranhall kieranhall merged commit beb6948 into master Aug 14, 2024
8 checks passed
@kieranhall kieranhall deleted the feature-2074 branch August 14, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web-wallet: Create DashboardNav component
2 participants