Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-data: fix to_str to not panic #2088

Merged
merged 1 commit into from
Aug 7, 2024
Merged

node-data: fix to_str to not panic #2088

merged 1 commit into from
Aug 7, 2024

Conversation

herr-seppia
Copy link
Member

No description provided.

fed-franz
fed-franz approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@fed-franz fed-franz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herr-seppia herr-seppia merged commit 8187d88 into master Aug 7, 2024
8 checks passed
@herr-seppia herr-seppia deleted the fix_node_tostr branch August 7, 2024 16:20
@goshawk-3 goshawk-3 mentioned this pull request Aug 14, 2024
Closed
@fed-franz fed-franz added the module:node-data Issues related to node-data module label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fed-franz fed-franz fed-franz approved these changes

@goshawk-3 goshawk-3 Awaiting requested review from goshawk-3

@HDauven HDauven Awaiting requested review from HDauven

Assignees
No one assigned
Labels
module:node-data Issues related to node-data module
Projects
Audits
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@herr-seppia @fed-franz