Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: fix overflow during faults validation #2087

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Conversation

herr-seppia
Copy link
Member

No description provided.

Copy link
Contributor

@fed-franz fed-franz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a comment to fix

node/src/chain/header_validation.rs Outdated Show resolved Hide resolved
node/src/chain/header_validation.rs Outdated Show resolved Hide resolved
Copy link
Member

@HDauven HDauven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herr-seppia herr-seppia merged commit 904ca44 into master Aug 8, 2024
8 checks passed
@herr-seppia herr-seppia deleted the fix-fault-overflow branch August 8, 2024 08:24
@fed-franz fed-franz added the module:node Issues related to node module label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:node Issues related to node module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants