node: Infallible pdu encoding #2079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herr-seppia
added
the
type:enhancement
herr-seppia
force-pushed
the
infallible-pdu-encode
branch
from
5c865a4 to
51172f0
Compare
goshawk-3
reviewed
Aug 7, 2024
| fn write_to_vec(&self) -> Vec<u8> { | ||
| let mut buffer = vec![]; | ||
| self.write(&mut buffer) | ||
| .expect("Writing to vec should succeed"); |
There was a problem hiding this comment.
Are we sure that there are no cases where an encoding may fail due to a programmer mistake/edge case thus panicking ?
There was a problem hiding this comment.
I believe you're right
I was too much tempted to remove those if let that I didn't take it into consideration
I'm going to move this back to draft and tackle it later in a better way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.