Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explorer: progress bar tests miss the ariaLabel required prop #2076

Merged
merged 1 commit into from
Aug 7, 2024
Merged

explorer: progress bar tests miss the ariaLabel required prop #2076

merged 1 commit into from
Aug 7, 2024

Conversation

ascartabelli
Copy link
Contributor

Resolves #2060

@ascartabelli ascartabelli self-assigned this Aug 5, 2024
kieranhall
kieranhall approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@kieranhall kieranhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for closing this gap!

@ascartabelli ascartabelli merged commit 5ec59a2 into master Aug 7, 2024
8 checks passed
@ascartabelli ascartabelli deleted the feature-2060 branch August 7, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kieranhall kieranhall kieranhall approved these changes

@deuch13 deuch13 Awaiting requested review from deuch13

@nortonandreev nortonandreev Awaiting requested review from nortonandreev

Assignees

@ascartabelli ascartabelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Progress bar tests miss the new required prop ariaLabel
2 participants
@ascartabelli @kieranhall