Change to use single-key signature scheme in contracts #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 1, 2024 15:32
By updating `bls12_381_bls` to `0.4` and changing the API to conform to it, as well as modifying the use of the functions accordingly, we change the scheme used for Moonlight and stake to be single-key, as opposed to multi-signature. This is not only faster, since it doesn't require key or signature aggregation, but also makes more semantic sense.
The host function is modified to ensure we verify the single-key scheme, as opposed to the multi-signature scheme.
ureeves
requested review from
miloszm,
fed-franz,
HDauven,
xevisalle,
moCello,
goshawk-3 and
herr-seppia
herr-seppia
reviewed
Aug 2, 2024
added 5 commits
August 2, 2024 12:44
Doing this allows us to remove the `StepSigError::EmptyApk` variant, since the BLS crate handles this situation already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By updating the version of
bls12_381_blsto0.4, we can leverage the improved API to seamlessly change to the single-key signature scheme for both Moonlight and the stake contract, with minimal changes to the codebase.The
consesus,node, andnode-datacrates do go through some changes, in particular to useBlsMultisigSignatureandBlsMultisigPublicKey. This results in a much more explicit usage of the multi-signature scheme than before.Resolves: #2044