Refactor rusk binary #2047
Merged
Refactor rusk binary #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herr-seppia
force-pushed
the
refactor-rusk-lib
branch
from
3d1e313 to
aeead26
Compare
herr-seppia
force-pushed
the
refactor-rusk-lib
branch
from
aeead26 to
f2682d0
Compare
- Add `can_handle` method - Change `Datasources` to support a vec of handlers
ureeves
requested changes
Jul 30, 2024
herr-seppia
force-pushed
the
refactor-rusk-lib
branch
from
f2682d0 to
9c97797
Compare
ZER0
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
LGTM, it's a first step in the right direction. As discussed during our pairing, the hierarchy of the components should be different from what it's now, but it's more about a mental model that we can change after this PR is landed, I don't want to delay it, so we can merge the events too.
ZER0
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor rusk binary in order to not require node module dependency:
RuskNodeBuilderto properly setup a node (useful for tests too)HandleRequestimpl