Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move rusk-abi functionalities to execution_core #2033

Merged
merged 15 commits into from
Aug 2, 2024
Merged

Move rusk-abi functionalities to execution_core #2033

merged 15 commits into from
Aug 2, 2024

Conversation

moCello
Copy link
Member

@moCello moCello commented Jul 26, 2024

Resolves #1859

@moCello moCello force-pushed the mocello/1859_abi branch 7 times, most recently from 363ce1b to 8055ad4 Compare July 30, 2024 14:10
ureeves
ureeves requested changes Jul 30, 2024
View reviewed changes
Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AccountPublicKey name seems to have crept in via some aliases in imports. Also, might it be a good idea to rename execution_core::transfer::contract_exec.

Apart from that looks very good!

rusk-recovery/src/state.rs Show resolved Hide resolved
execution-core/src/transfer.rs Show resolved Hide resolved
herr-seppia
herr-seppia previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

contracts/transfer/src/transitory.rs Outdated Show resolved Hide resolved
ureeves
ureeves previously approved these changes Aug 2, 2024
View reviewed changes
@moCello moCello dismissed stale reviews from ureeves and herr-seppia via 6ce1015 August 2, 2024 12:29
moCello added 13 commits August 2, 2024 15:12
@moCello
rusk-abi: Move functionalities to execution-core
a3f068a
@moCello
execution-core: Add rusk-abi types and functionality
5512133
@moCello
alice: Move rusk-abi functionalities to execution-core
06f5349
@moCello
host-fn: Move rusk-abi functionalities to execution-core
26cfe76
@moCello
license-contract: Move rusk-abi functionalities to execution-core
e060137
@moCello
license-circuits: Restructure execution-core
8c2799f
@moCello
stake-contract: Move rusk-abi functionalities to execution-core
1d10c60
@moCello
transfer-contract: Move rusk-abi functionalities to execution-core
6947ab0
@moCello
node: Move rusk-abi functionalities to execution-core
4189e7e
@moCello
test-wallet: Move rusk-abi functionalities to execution-core
4972b96
@moCello
rusk-recovery: Move rusk-abi functionalities to execution-core
ddc9490
@moCello
rusk: Move rusk-abi functionalities to execution-core
5d670c2
@moCello
rusk-prover: Restructure execution-core
533e032
@moCello moCello merged commit 7f13eb5 into master Aug 2, 2024
8 checks passed
@moCello moCello deleted the mocello/1859_abi branch August 2, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ureeves ureeves ureeves approved these changes

@herr-seppia herr-seppia herr-seppia left review comments

@miloszm miloszm Awaiting requested review from miloszm

@goshawk-3 goshawk-3 Awaiting requested review from goshawk-3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move rusk-abi functionalities into execution-core
3 participants
@moCello @ureeves @herr-seppia