Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explorer: Create and implement stale data warning #2012

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Conversation

deuch13
Copy link
Contributor

@deuch13 deuch13 commented Jul 24, 2024

Resolves #1892

@deuch13 deuch13 changed the title Feature 1892 Create and implement stale data warning Jul 24, 2024
@deuch13 deuch13 force-pushed the feature-1892 branch 2 times, most recently from 3a57832 to 0b6b2a0 Compare July 25, 2024 10:44
@deuch13 deuch13 marked this pull request as ready for review July 25, 2024 10:45
@deuch13 deuch13 changed the title Create and implement stale data warning explorer: Create and implement stale data warning Jul 25, 2024
@deuch13 deuch13 added the module:explorer Issues related to explorer module label Jul 25, 2024
Copy link
Contributor

@ascartabelli ascartabelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor issue, good to merge otherwise.

@ascartabelli
Copy link
Contributor

Remember to also add a changelog entry.

@deuch13 deuch13 merged commit e3616d8 into master Jul 26, 2024
8 checks passed
@deuch13 deuch13 deleted the feature-1892 branch July 26, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:explorer Issues related to explorer module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn the user that market data is stale in case of error
2 participants