Refactor Attestation verification #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fed-franz
force-pushed
the
refactor_verify_att
branch
from
39576f9 to
8427751
Compare
fed-franz
changed the title
fed-franz
force-pushed
the
refactor_verify_att
branch
2 times, most recently
from
27fe6da to
e4ca204
Compare
Fixes a bug in verify_att, which returned the set of all committee members instead of just the actual voters. verify_votes is modified to return the set of voters corresponding to the quorum committee. verify_step_votes is modified to return a vector of voters instead of a committee.
Fixes a bug in verify_att, which returned the set of all committee members instead of just the actual voters. - verify_att now get voters from verify_step_votes and merge them by using merge_voters. - merge_committees is deleted as redundant
Allow verify_att to check if the Attestation result is what expected. - verify_att now takes expected_result and check it against att - verify_success_att is removed as redundant
fed-franz
force-pushed
the
refactor_verify_att
branch
from
f657ef6 to
abbc821
Compare
herr-seppia
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename:
verify_block_atttoverify_attVoterWithCredittoVoterAdd:
to_consensus_headermethod forHeaderto_votersmethod forCluster<PublicKey>get_step_votersget_step_committeemerge_votersRemove:
verify_quorumverify_success_attmerge_committeesRefactor:
get_votersis modified to only return voters, without re-verifying the attestationverify_attis modified to get aconsensus_headerparameterverify_attis modified to checks the expected resultVoteris modified to be(PublicKey, usize)to ease its handlingreward_slash_and_update_rootis updated as a consequenceBugfixes:
verify_attto correctly return the set of voters, instead of the whole committees