Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus: Reduce the total number of iterations #1983

Merged
merged 6 commits into from
Jul 23, 2024
Merged

Conversation

herr-seppia
Copy link
Member

@herr-seppia herr-seppia commented Jul 17, 2024

Resolves #1830

Blocked by #1962

@herr-seppia herr-seppia force-pushed the max_iter_50 branch 2 times, most recently from 4bc0e21 to 66e7fec Compare July 18, 2024 08:29
@herr-seppia herr-seppia changed the base branch from master to fix-1907 July 18, 2024 08:30
@herr-seppia herr-seppia marked this pull request as ready for review July 18, 2024 08:30
fed-franz
fed-franz previously approved these changes Jul 18, 2024
Copy link
Contributor

@fed-franz fed-franz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from fix-1907 to master July 23, 2024 06:55
@herr-seppia herr-seppia dismissed fed-franz’s stale review July 23, 2024 06:55

The base branch was changed.

@herr-seppia herr-seppia requested a review from fed-franz July 23, 2024 06:56
@herr-seppia herr-seppia merged commit 6a2b047 into master Jul 23, 2024
8 checks passed
@herr-seppia herr-seppia deleted the max_iter_50 branch July 23, 2024 08:05
@fed-franz fed-franz added the module:consensus Issues related to consensus module label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:consensus Issues related to consensus module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

consensus: Reduce the total number of iterations
2 participants