Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consensus: handle Faults proof (aka hard slash) #1944

Merged
merged 4 commits into from
Jul 17, 2024
Merged

consensus: handle Faults proof (aka hard slash) #1944

merged 4 commits into from
Jul 17, 2024

Conversation

herr-seppia
Copy link
Member

@herr-seppia herr-seppia commented Jul 5, 2024 •
edited
Loading

This is a followup of #1923

  • Collect faults to process during proposal step tracked by node: Collect faults to process during proposal step #1969
  • Hard slash during proposal if any faults (change EST/VST/AST)
  • Check fault proofs while verifying block
    • Check if fault has been already slashed
    • Verify proof signatures
  • Discard obsoleted proofs

See also #1651

@herr-seppia herr-seppia changed the base branch from master to add_fauls July 5, 2024 15:17
@herr-seppia herr-seppia mentioned this pull request Jul 5, 2024
Closed
@herr-seppia herr-seppia force-pushed the hard_slash_trigger branch from 82996e3 to c846375 Compare July 8, 2024 10:17
@herr-seppia herr-seppia force-pushed the hard_slash_trigger branch from c846375 to 2671e4b Compare July 8, 2024 14:16
Base automatically changed from add_fauls to master July 9, 2024 08:09
@herr-seppia herr-seppia force-pushed the hard_slash_trigger branch 6 times, most recently from 38b6327 to c4e1c15 Compare July 15, 2024 13:30
@herr-seppia herr-seppia changed the title consensus: trigger hard slash consensus: handle Faults proof (aka hard slash) Jul 15, 2024
@herr-seppia herr-seppia marked this pull request as ready for review July 15, 2024 13:30
fed-franz
fed-franz requested changes Jul 15, 2024
View reviewed changes
node-data/src/ledger/faults.rs Outdated Show resolved Hide resolved
node-data/src/ledger/header.rs Outdated Show resolved Hide resolved
node/src/chain/acceptor.rs Outdated Show resolved Hide resolved
@herr-seppia herr-seppia requested a review from fed-franz July 16, 2024 08:41
@herr-seppia herr-seppia force-pushed the hard_slash_trigger branch 4 times, most recently from f83f8dc to a5f5c6d Compare July 16, 2024 14:37
fed-franz
fed-franz requested changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@fed-franz fed-franz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

node-data/src/ledger/faults.rs Outdated Show resolved Hide resolved
node-data/src/ledger/faults.rs Outdated Show resolved Hide resolved
node/src/chain/header_validation.rs Outdated Show resolved Hide resolved
node-data/src/ledger/faults.rs Outdated Show resolved Hide resolved
node-data/src/ledger.rs Outdated Show resolved Hide resolved
node/src/chain/header_validation.rs Outdated Show resolved Hide resolved
rusk/src/lib/chain/rusk.rs Show resolved Hide resolved
@herr-seppia
node-data: add Slash, SlashType and InvalidFault
0bd9828
@herr-seppia
consensus: change CallParams to accept Vec<Slash>
3a33597
@herr-seppia
node: support Slash structs
a4c89dc 
- Change CallParams to use `Slash` array instead of missing generators
- Implement `operations::Error`
- Add `verify_faults` while verifying transactions
@herr-seppia herr-seppia requested a review from fed-franz July 17, 2024 09:09
fed-franz
fed-franz approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@fed-franz fed-franz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herr-seppia herr-seppia merged commit e06fbab into master Jul 17, 2024
8 checks passed
@herr-seppia herr-seppia deleted the hard_slash_trigger branch July 17, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fed-franz fed-franz fed-franz approved these changes

@autholykos autholykos Awaiting requested review from autholykos

@goshawk-3 goshawk-3 Awaiting requested review from goshawk-3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@herr-seppia @fed-franz