transfer-contract: Add deposit to remainder-note and remove bool return for mint #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moCello
force-pushed
the
mocello/transfer_contract_fixup
branch
2 times, most recently
from
33b2c22 to
198ed69
Compare
moCello
changed the title
moCello
force-pushed
the
mocello/transfer_contract_fixup
branch
from
198ed69 to
5135734
Compare
HDauven
approved these changes
Jul 4, 2024
The changelog of the transfer-contract is not used. We would need to update but I would tackle that in a different issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the collected requests for changes to the transfer-contract from #1822.
Most notably:
The deposit, if not picked up by a contract, will be refunded together with the gas-refund
The function
mintdoesn't return a boolean anymore and the comments are adjusted.Only the stake-contract is allowed to call the
mintfunction.