-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stake-contract: Implement new hard slashing #1925
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fed-franz
force-pushed
the
hard_slash
branch
2 times, most recently
from
July 3, 2024 16:04
45764a0
to
40548d0
Compare
herr-seppia
requested changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the hard_faults
reset on reward.
Fixed and added a test |
herr-seppia
previously approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change the code to slash the stake incrementally, depending on the number of 'hard_faults'. The stake is slashed by 10% times the number of faults. The 'severity' parameter can be used to increase 'hard_faults' by more than 1. The slashed stake is also suspended for the resto of the current epoch plus 'hard_faults'additional epochs. See also #1651
herr-seppia
approved these changes
Jul 4, 2024
herr-seppia
added
module:contracts
Issues related to the genesis contracts
and removed
module:consensus
Issues related to consensus module
labels
Jul 5, 2024
herr-seppia
changed the title
Implement new hard slashing
stake-contract: Implement new hard slashing
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Implements #1651
The second part (enabling generators to include proofs of hard faults) is addressed by #1923