Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explorer: add number of displayed entries on table header #1868

Merged
merged 1 commit into from
Jun 25, 2024
Merged

explorer: add number of displayed entries on table header #1868

merged 1 commit into from
Jun 25, 2024

Conversation

deuch13
Copy link
Contributor

@deuch13 deuch13 commented Jun 19, 2024

Resolves #1748

@deuch13 deuch13 added the module:explorer Issues related to explorer module label Jun 19, 2024
@deuch13 deuch13 self-assigned this Jun 19, 2024
@deuch13 deuch13 requested a review from nortonandreev June 19, 2024 14:09
ascartabelli
ascartabelli approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@ascartabelli ascartabelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge, but is there a reason for having the words capitalized?
Wouldn't be better to have "displayed items" instead?

@deuch13
Copy link
Contributor Author

deuch13 commented Jun 25, 2024

Good to merge, but is there a reason for having the words capitalized? Wouldn't be better to have "displayed items" instead?

The only reason I have is that the design has the text capitalized.

@deuch13 deuch13 merged commit b32f533 into master Jun 25, 2024
8 checks passed
@deuch13 deuch13 deleted the feature-1748 branch June 25, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascartabelli ascartabelli ascartabelli approved these changes

@nortonandreev nortonandreev Awaiting requested review from nortonandreev

Assignees

@deuch13 deuch13

Labels
module:explorer Issues related to explorer module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Give visual feedback after a "show more" click
2 participants
@deuch13 @ascartabelli