Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explorer: Fix Links low contrast #1778

Merged
merged 1 commit into from
May 28, 2024
Merged

explorer: Fix Links low contrast #1778

merged 1 commit into from
May 28, 2024

Conversation

nortonandreev
Copy link
Contributor

Resolves #1764

Screenshot 2024-05-22 at 17 58 56

@nortonandreev nortonandreev self-assigned this May 22, 2024
kieranhall
kieranhall previously approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@kieranhall kieranhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We will need to revisit (probably) once the Duskit design language is finalised, but that's just something to be aware of for the future.

@nortonandreev
Copy link
Contributor Author

Looks good. We will need to revisit (probably) once the Duskit design language is finalised, but that's just something to be aware of for the future.

I agree. We could make use of more of the shades for the different states, etc.

@nortonandreev nortonandreev force-pushed the feature-1764 branch 2 times, most recently from b9b9884 to 7755561 Compare May 23, 2024 10:20
@nortonandreev nortonandreev requested a review from kieranhall May 23, 2024 10:21
@nortonandreev nortonandreev force-pushed the feature-1764 branch 2 times, most recently from f5d8b3d to 6550a1d Compare May 25, 2024 15:05
@nortonandreev
Copy link
Contributor Author

@kieranhall I have fixed the conflicts with the main, could I get a re-review, please?

kieranhall
kieranhall approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@kieranhall kieranhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nortonandreev nortonandreev merged commit aab520a into master May 28, 2024
8 checks passed
@nortonandreev nortonandreev deleted the feature-1764 branch May 28, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kieranhall kieranhall kieranhall approved these changes

@deuch13 deuch13 Awaiting requested review from deuch13

@ascartabelli ascartabelli Awaiting requested review from ascartabelli

Assignees

@nortonandreev nortonandreev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

explorer: Low contrast for links
2 participants
@nortonandreev @kieranhall