Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explorer: remove block height from Block Details card header #1739

Merged
merged 1 commit into from
May 15, 2024
Merged

explorer: remove block height from Block Details card header #1739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion explorer/src/lib/components/__tests__/__snapshots__/BlockDetails.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ exports[`Block Details > renders the Block Details component 1`] = `
<h1
class="data-card__header-title"
>
Block Details - #495,868
Block Details
</h1>

<button
Expand Down
4 changes: 3 additions & 1 deletion explorer/src/lib/components/__tests__/__snapshots__/BlocksCard.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,7 +830,9 @@ exports[`Blocks Card > should disable the \`Show More\` button is the card is in
<!--&lt;Button&gt;-->
</header>

<p>
<p
class="data-card__loading-notice"
>
Loading...
</p>

Expand Down
4 changes: 3 additions & 1 deletion explorer/src/lib/components/__tests__/__snapshots__/TransactionsCard.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ exports[`Transactions Card > should disable the \`Show More\` button if the card
<!--&lt;Button&gt;-->
</header>

<p>
<p
class="data-card__loading-notice"
>
Loading...
</p>

Expand Down
11 changes: 1 addition & 10 deletions explorer/src/lib/components/block-details/BlockDetails.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,8 @@
/** @type {Number} */
let screenWidth = window.innerWidth;

/** @type {string}*/
let blockHeight = "";

$: classes = makeClassName(["block-details", className]);

$: {
if (data) {
blockHeight = `#${formatter(data.header.height)}`;
}
}

onMount(() => {
const resizeObserver = new ResizeObserver((entries) => {
const entry = entries[0];
Expand All @@ -62,7 +53,7 @@
{error}
{loading}
className={classes}
title="Block Details - {blockHeight}"
title="Block Details"
headerButtonDetails={{
action: () => history.back(),
disabled: false,
Expand Down
1 change: 0 additions & 1 deletion explorer/src/lib/components/data-card/DataCard.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,4 @@
text-transform: uppercase;
font-size: 1.125rem;
line-height: 32.2px;
letter-spacing: -1%;
}
Loading