Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explorer: Add a reset method to data stores #1736

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

ascartabelli
Copy link
Contributor

Resolves #1732

@ascartabelli ascartabelli self-assigned this May 14, 2024
@ascartabelli ascartabelli marked this pull request as draft May 15, 2024 08:36
@ascartabelli ascartabelli force-pushed the feature-1732 branch 3 times, most recently from b56aeed to fa8b48d Compare May 20, 2024 10:04
@ascartabelli ascartabelli marked this pull request as ready for review May 20, 2024 10:09
@ascartabelli ascartabelli requested a review from kieranhall May 20, 2024 10:09
Copy link
Contributor

@deuch13 deuch13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, everything else looks ok

- the `dataStore.getData` method now starts a new call and ignore the previous one
- the `pollingDataStore.start` method now starts a new poll and ignore the previous one
- updated `StatisticsPanel` to accomodate the new behaviours

Resolves #1732
@ascartabelli ascartabelli merged commit a898ba2 into master May 20, 2024
8 checks passed
@ascartabelli ascartabelli deleted the feature-1732 branch May 20, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a reset method to data stores
2 participants