Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web-wallet: Fix build warning for unused icon #1633

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

nortonandreev
Copy link
Contributor

Resolves #1632

Copy link
Contributor

@ascartabelli ascartabelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of notes.
This effectively solves the problem, thanks, as it was annoying.
I think we need to understand better why the build system sees a problem here.

One last thought: should we remove the components-showcase from the production build altogether?

web-wallet/CHANGELOG.md Outdated Show resolved Hide resolved
@nortonandreev
Copy link
Contributor Author

One last thought: should we remove the components-showcase from the production build altogether?

I think this would make sense to do, once we have the Duskit library with a publicly accessible components showcase (and once we have migrated to use it across the project).

I think it's useful to have the design language / system publicly accessible so that the stakeholders can have a quick look easily. Like, for example, if Giancarlo wanted a preview of the way all the Button variants were implemented in the code.

@nortonandreev nortonandreev merged commit 5448a71 into master Apr 10, 2024
8 checks passed
@nortonandreev nortonandreev deleted the feature-1632 branch April 10, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web-wallet: Build Warning for Unused Icon in Toast within on:click Handler
2 participants