Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transfer-contract: Add expiration for roots #1626

Merged
merged 1 commit into from
Apr 15, 2024
Merged

transfer-contract: Add expiration for roots #1626

merged 1 commit into from
Apr 15, 2024

Conversation

herr-seppia
Copy link
Member

@herr-seppia herr-seppia commented Apr 9, 2024 •
edited
Loading

See also #316

@herr-seppia herr-seppia linked an issue Apr 9, 2024 that may be closed by this pull request
Create a fixed size list for BlsScalar #316
Closed
@HDauven HDauven requested a review from ureeves April 10, 2024 11:56
ureeves
ureeves previously approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@ureeves ureeves left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice solution! That said, maybe we should consider making this list larger? Remember that this also sets an expiration for transactions.

@herr-seppia herr-seppia requested a review from ureeves April 11, 2024 08:14
@herr-seppia herr-seppia added the module:contracts Issues related to the genesis contracts label Apr 15, 2024
@herr-seppia herr-seppia merged commit e0680d2 into master Apr 15, 2024
8 checks passed
@herr-seppia herr-seppia deleted the discard-roots branch April 15, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ureeves ureeves ureeves approved these changes

Assignees
No one assigned
Labels
module:contracts Issues related to the genesis contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a fixed size list for BlsScalar
2 participants
@herr-seppia @ureeves