Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stake-contract: optimized get_provisioners #1459

Merged
merged 4 commits into from
Mar 8, 2024
Merged

stake-contract: optimized get_provisioners #1459

merged 4 commits into from
Mar 8, 2024

Conversation

miloszm
Copy link
Contributor

@miloszm miloszm commented Feb 23, 2024

get_provisioners optimisation of the stake contract,
implements #1447

@miloszm miloszm requested a review from herr-seppia February 23, 2024 15:20
@miloszm miloszm force-pushed the issue-1447-stake-contract branch from 1ccf0a9 to dc75c8f Compare February 23, 2024 16:00
@miloszm miloszm requested a review from herr-seppia February 23, 2024 16:43
herr-seppia
herr-seppia previously approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herr-seppia
Copy link
Member

Since you have to rebase, do you mind to invert the following commits?

Just to be able to perform benchmarks on old code too

@herr-seppia
Copy link
Member

Just to track down results for 1000 provisioners

Benchmarking get_provisioners: Warming up for 3.0000 s
Warning: Unable to complete 10 samples in 5.0s. You may wish to increase target time to 208.9s.
get_provisioners        time:   [20.827 s 20.845 s 20.863 s]

Benchmarking get_provisioners: Warming up for 3.0000 s
get_provisioners        time:   [2.3989 ms 2.4062 ms 2.4138 ms]
                        change: [-99.988% -99.988% -99.988%] (p = 0.00 < 0.05)
                        Performance has improved.

@herr-seppia herr-seppia force-pushed the issue-1447-stake-contract branch from f52d524 to 87e2c44 Compare March 8, 2024 09:20
@herr-seppia herr-seppia force-pushed the issue-1447-stake-contract branch from adc2868 to dce73fb Compare March 8, 2024 10:08
autholykos
autholykos approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@autholykos autholykos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miloszm miloszm merged commit f043fbf into master Mar 8, 2024
6 checks passed
@miloszm miloszm deleted the issue-1447-stake-contract branch March 8, 2024 11:03
@HDauven HDauven mentioned this pull request Apr 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@autholykos autholykos autholykos approved these changes

@herr-seppia herr-seppia Awaiting requested review from herr-seppia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miloszm @herr-seppia @autholykos