Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lazy-initialization for all services #1454

Merged
merged 5 commits into from
Feb 27, 2024
Merged

Conversation

goshawk-3
Copy link
Contributor

Any services registered may introduce an implementation of Initialize in which method any major components/structs/resources can be fully instantiated. On implementing Initialize, ChainSrv instantiates Acceptor struct by which it can revert to last final state before spawning DataBroker service.

@goshawk-3 goshawk-3 marked this pull request as ready for review February 23, 2024 08:26
herr-seppia
herr-seppia previously approved these changes Feb 26, 2024
Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a nit

node/src/chain.rs Outdated Show resolved Hide resolved
@herr-seppia herr-seppia linked an issue Feb 26, 2024 that may be closed by this pull request
@goshawk-3 goshawk-3 merged commit 33577c2 into master Feb 27, 2024
6 checks passed
@goshawk-3 goshawk-3 deleted the init_services branch February 27, 2024 10:06
herr-seppia added a commit to dusk-network/node-installer that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node Broadcasts Blocks Prematurely
2 participants