Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web-wallet: Change Get Quote API Endpoint to ENV variable #1428

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

nortonandreev
Copy link
Contributor

Resolves: #1311

@nortonandreev nortonandreev self-assigned this Feb 19, 2024
@nortonandreev nortonandreev marked this pull request as draft February 19, 2024 13:52
@nortonandreev nortonandreev marked this pull request as ready for review February 19, 2024 13:54
Copy link
Contributor

@deuch13 deuch13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has the ENV been added to the DO application?

@nortonandreev
Copy link
Contributor Author

Has the ENV been added to the DO application?

Not yet. I am also not sure how the ENV variables impact the wallet when it's delivered with the node. I want to discuss with Hein when he is less busy.

@deuch13 deuch13 self-requested a review February 20, 2024 14:22
deuch13
deuch13 previously approved these changes Feb 20, 2024
@deuch13
Copy link
Contributor

deuch13 commented Feb 20, 2024

Fulvio has added the env to the DO app, this can be merge after rebasing and resolving the conflicts.

@nortonandreev nortonandreev merged commit abfd345 into master Feb 20, 2024
6 checks passed
@nortonandreev nortonandreev deleted the feature-1311 branch February 20, 2024 15:25
@nortonandreev nortonandreev added the module:web-wallet Issues related to web-wallet module label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:web-wallet Issues related to web-wallet module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract the Quote API URL as an ENV var
2 participants