Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consensus: ignore candidate with wrong prev_block_hash #1355

Merged
merged 25 commits into from
Feb 12, 2024
Merged

consensus: ignore candidate with wrong prev_block_hash #1355

merged 25 commits into from
Feb 12, 2024

Conversation

herr-seppia
Copy link
Member

@herr-seppia herr-seppia commented Feb 8, 2024 •
edited
Loading

Additionally:

  • Change quorum terminology to reflect new names defined in consensus: Implement new Validation and Ratification logic #1268
  • Refactor codebase to get rid of unused function arguments
  • Refactor codebase to be more idiomatic
  • Fix validation::collect_from_past from returning a final_result even if the quorum is not reached
  • Adapt node benches to previous PRs changes

Resolves #1183

@herr-seppia herr-seppia marked this pull request as ready for review February 8, 2024 10:38
ureeves
ureeves previously approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some small things that shouldn't block merging.

consensus/src/commons.rs Show resolved Hide resolved
consensus/src/ratification/handler.rs Show resolved Hide resolved
consensus/src/user/committee.rs Show resolved Hide resolved
@herr-seppia herr-seppia self-assigned this Feb 8, 2024
fed-franz
fed-franz previously approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@fed-franz fed-franz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herr-seppia herr-seppia dismissed stale reviews from fed-franz and ureeves via 64c7619 February 9, 2024 14:30
@herr-seppia herr-seppia force-pushed the ignore-wrong_prevblock branch 2 times, most recently from c0c0b1a to c53fa21 Compare February 9, 2024 16:20
@herr-seppia herr-seppia force-pushed the ignore-wrong_prevblock branch 2 times, most recently from 4649a21 to e308fb6 Compare February 12, 2024 09:13
@herr-seppia
node-data: change QuorumType to reflect new naming
e891563 
See also #1268
@herr-seppia
consensus: change QuorumType to reflect new naming
fec2f7a 
Additionally, check that validationHandler is not receiving Vote::NoQuorum
@herr-seppia
consensus: change quorum::send to not clone message
1491697
@herr-seppia
consensus: fix validation::collect_from_past
335f407 
validation::collect_from_past is wrongly return a final_result even if the quorum is not reached
@herr-seppia
consensus: remove AggrSigError
fc74250
@herr-seppia
consensus: change collect_vote to return Result
ac0818d
@herr-seppia
consensus: log errors while receiving message in execution_ctx
0b7e3f5
@herr-seppia
consensus: change RatificationHandler::reset to take validation result
ff3d790
@herr-seppia
node-data: change visibility of vote related structs fields
56649ac
@herr-seppia
consensus: change verify_votes to take StepVotes param
2c4993e
@herr-seppia
consensus: remove step_votes registry from proposal handler
3f50600
@herr-seppia
consensus: remove unused parameters from MsgHandler::verify
72730fe
@herr-seppia
consensus: ignore candidate with wrong prev_block_hash
cd0716b 
Resolves #1183
@herr-seppia
node: update benches
a39c606
@herr-seppia
consensus: change quorum reached event to log actual votes target
ad5a839
@herr-seppia
node: fix average_step to be between MIN and MAX step timeout
4a68f9f
@herr-seppia
node: change METADATA_KEYS to be slice
cbf9eb3
@herr-seppia herr-seppia force-pushed the ignore-wrong_prevblock branch from e38d14c to cbf9eb3 Compare February 12, 2024 09:54
@herr-seppia herr-seppia merged commit 9ffa209 into master Feb 12, 2024
6 checks passed
@herr-seppia herr-seppia deleted the ignore-wrong_prevblock branch February 12, 2024 10:10
@fed-franz fed-franz mentioned this pull request Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goshawk-3 goshawk-3 goshawk-3 approved these changes

@autholykos autholykos Awaiting requested review from autholykos

@ureeves ureeves Awaiting requested review from ureeves

@fed-franz fed-franz Awaiting requested review from fed-franz

Assignees

@herr-seppia herr-seppia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

consensus: Ignore candidate with wrong prev_block_hash
4 participants
@herr-seppia @fed-franz @ureeves @goshawk-3