Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consensus: change Quorum to use Certificates with RatificationResult #1346

Merged
merged 14 commits into from
Feb 14, 2024
Merged

consensus: change Quorum to use Certificates with RatificationResult #1346

merged 14 commits into from
Feb 14, 2024

Conversation

herr-seppia
Copy link
Member

@herr-seppia herr-seppia commented Feb 6, 2024 •
edited
Loading

See also #1268

@herr-seppia herr-seppia force-pushed the new-ratification branch 3 times, most recently from 446e881 to d723df8 Compare February 8, 2024 10:44
@herr-seppia herr-seppia changed the base branch from master to ignore-wrong_prevblock February 8, 2024 10:44
@herr-seppia herr-seppia self-assigned this Feb 8, 2024
@herr-seppia herr-seppia force-pushed the ignore-wrong_prevblock branch 3 times, most recently from c53fa21 to 4649a21 Compare February 10, 2024 09:12
@herr-seppia herr-seppia force-pushed the ignore-wrong_prevblock branch from 4649a21 to e308fb6 Compare February 12, 2024 09:13
@herr-seppia herr-seppia linked an issue Feb 12, 2024 that may be closed by this pull request
consensus: Implement new Validation and Ratification logic #1268
Closed
@herr-seppia herr-seppia force-pushed the new-ratification branch 2 times, most recently from b0e1d94 to 531eff5 Compare February 12, 2024 09:51
@herr-seppia herr-seppia force-pushed the ignore-wrong_prevblock branch from e38d14c to cbf9eb3 Compare February 12, 2024 09:54
Base automatically changed from ignore-wrong_prevblock to master February 12, 2024 10:10
@herr-seppia herr-seppia force-pushed the new-ratification branch 5 times, most recently from eb4479c to 26f1113 Compare February 13, 2024 10:50
@herr-seppia herr-seppia marked this pull request as ready for review February 13, 2024 10:56
@herr-seppia herr-seppia changed the title WIP: New ratification consensus: change Quorum to use Certificates with RatificationResult Feb 13, 2024
@herr-seppia herr-seppia removed a link to an issue Feb 13, 2024
consensus: Implement new Validation and Ratification logic #1268
Closed
fed-franz
fed-franz reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@fed-franz fed-franz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a doubt to clarify on verify_votes

consensus/src/quorum/verifiers.rs Show resolved Hide resolved
consensus/src/quorum/task.rs Show resolved Hide resolved
@herr-seppia herr-seppia merged commit d64dad2 into master Feb 14, 2024
6 checks passed
@herr-seppia herr-seppia deleted the new-ratification branch February 14, 2024 10:58
@herr-seppia herr-seppia mentioned this pull request Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goshawk-3 goshawk-3 goshawk-3 left review comments

@fed-franz fed-franz fed-franz approved these changes

Assignees

@herr-seppia herr-seppia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@herr-seppia @fed-franz @goshawk-3