Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rusk: Remove allowlist #1257

Merged
merged 22 commits into from
Jan 18, 2024
Merged

rusk: Remove allowlist #1257

merged 22 commits into from
Jan 18, 2024

Conversation

herr-seppia
Copy link
Member

@herr-seppia herr-seppia commented Jan 15, 2024 •
edited
Loading

stake-contract:

  • Remove allowlist
  • Add slash call

node-data:

  • Change FailedIterations to include iterator's generator too

consensus:

  • Change FailedIterations to include only nil quorum certificates

node:

  • Add failed generator check during header validation

rusk:

  • Change rusk::provisioners to filter out slashed stakes
  • Change block processing to slash failed iterations provisioner

@herr-seppia herr-seppia force-pushed the slash branch 13 times, most recently from efa9d45 to 7f55ff1 Compare January 17, 2024 09:02
@herr-seppia herr-seppia changed the title Remove allowlist rusk: Remove allowlist Jan 17, 2024
@herr-seppia herr-seppia marked this pull request as ready for review January 17, 2024 10:10
fed-franz
fed-franz requested changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@fed-franz fed-franz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.
Few nits and comments

rusk/CHANGELOG.md Outdated Show resolved Hide resolved
rusk/CHANGELOG.md Outdated Show resolved Hide resolved
rusk/src/lib/lib.rs Outdated Show resolved Hide resolved
rusk/src/lib/lib.rs Show resolved Hide resolved
rusk/src/lib/vm.rs Show resolved Hide resolved
rusk/src/lib/vm.rs Outdated Show resolved Hide resolved
node-data/src/ledger.rs Show resolved Hide resolved
contracts/stake/src/state.rs Outdated Show resolved Hide resolved
consensus/src/ratification/handler.rs Outdated Show resolved Hide resolved
consensus/src/ratification/handler.rs Outdated Show resolved Hide resolved
@herr-seppia herr-seppia force-pushed the slash branch 2 times, most recently from ea4a43c to 9a5a39d Compare January 17, 2024 14:49
@herr-seppia herr-seppia requested a review from fed-franz January 17, 2024 14:59
goshawk-3
goshawk-3 reviewed Jan 17, 2024
View reviewed changes
rusk/src/lib/vm.rs Outdated Show resolved Hide resolved
rusk/src/lib/lib.rs Show resolved Hide resolved
@herr-seppia
rusk-recovery: remove allowlist
5bcf0e5
@herr-seppia
examples: remove allowlist
5d239fc
@herr-seppia
stake-contract: remove allowlist
16b2bed
@herr-seppia
stake-type: remove allow related structs
36007e7
@herr-seppia
rusk: remove allowlist
de1be2e
@herr-seppia
rusk: remove deprecated tests
b6f16b5
@herr-seppia
transfer-contract: add sub_module_balance callable by stake-contract
e230cc7
@herr-seppia
stake-contract: add slash calls
47a898c 
- Add `slash` management call
- Add `slashed_amount` query
@herr-seppia
rusk: change rusk::provisioners to filter out slashed stakes
ba41142
@herr-seppia
rusk-recovery: remove MINIMUM_STAKE const
a47a56f
@herr-seppia
consensus: change VST to verify a Block instead of CallParams
f598c65
@herr-seppia
node: change VST to verify a Block instead of CallParams
e34676f
@herr-seppia
rusk: change VST to verify a Block instead of CallParams
340cd4a
@herr-seppia
node-data: add Generator to IterationInfo
c5bc261
@herr-seppia
consensus: add Generator to IterationInfo
78c2423
@herr-seppia
node: add failed generator check during header validation
7dbd800
@herr-seppia
consensus: change get_nil_certificates to return only nil quorums
66fc2a0
@herr-seppia
node: change header validation to check nil quorums
fd72b61
@herr-seppia
rusk: change block processing to slash failed iterations provisioner
88d7c57
@herr-seppia
rusk: add slash tests
8a7e9ad
@herr-seppia
node: update provisioners if slash has been applied
16b2446
@herr-seppia
rusk: update CHANGELOG.md
6421dc4
fed-franz
fed-franz approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@fed-franz fed-franz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ureeves
ureeves approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@herr-seppia herr-seppia merged commit 7fd05b9 into master Jan 18, 2024
3 checks passed
@herr-seppia herr-seppia deleted the slash branch January 18, 2024 14:01
@herr-seppia herr-seppia mentioned this pull request Jan 18, 2024
Merged
@fed-franz fed-franz mentioned this pull request Jan 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ureeves ureeves ureeves approved these changes

@fed-franz fed-franz fed-franz approved these changes

@autholykos autholykos Awaiting requested review from autholykos

@ZER0 ZER0 Awaiting requested review from ZER0

@HDauven HDauven Awaiting requested review from HDauven

@goshawk-3 goshawk-3 Awaiting requested review from goshawk-3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@herr-seppia @fed-franz @ureeves @goshawk-3