-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consensus: fix_step_votes_registry #1254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herr-seppia
force-pushed
the
fix_step_votes_registry
branch
from
January 12, 2024 09:03
008885c
to
03a17ac
Compare
goshawk-3
suggested changes
Jan 12, 2024
fed-franz
requested changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few nits
fed-franz
reviewed
Jan 12, 2024
fed-franz
reviewed
Jan 12, 2024
herr-seppia
force-pushed
the
fix_step_votes_registry
branch
from
January 12, 2024 14:16
3718c57
to
8374a20
Compare
fed-franz
approved these changes
Jan 12, 2024
herr-seppia
force-pushed
the
fix_step_votes_registry
branch
from
January 13, 2024 11:04
8374a20
to
8512bcb
Compare
goshawk-3
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing collection of failed cert when a valid vote is received firstly
See also #1255