Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus: fix_step_votes_registry #1254

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Conversation

herr-seppia
Copy link
Member

@herr-seppia herr-seppia commented Jan 11, 2024

Fix missing collection of failed cert when a valid vote is received firstly

See also #1255

@herr-seppia herr-seppia force-pushed the fix_step_votes_registry branch from 008885c to 03a17ac Compare January 12, 2024 09:03
@herr-seppia herr-seppia marked this pull request as ready for review January 12, 2024 10:40
consensus/src/step_votes_reg.rs Outdated Show resolved Hide resolved
consensus/src/step_votes_reg.rs Show resolved Hide resolved
@herr-seppia herr-seppia requested a review from goshawk-3 January 12, 2024 12:31
Copy link
Contributor

@fed-franz fed-franz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits

consensus/src/step_votes_reg.rs Outdated Show resolved Hide resolved
consensus/src/step_votes_reg.rs Outdated Show resolved Hide resolved
@herr-seppia herr-seppia force-pushed the fix_step_votes_registry branch from 3718c57 to 8374a20 Compare January 12, 2024 14:16
@herr-seppia herr-seppia requested a review from fed-franz January 12, 2024 14:17
@herr-seppia herr-seppia force-pushed the fix_step_votes_registry branch from 8374a20 to 8512bcb Compare January 13, 2024 11:04
@goshawk-3 goshawk-3 removed their request for review January 15, 2024 13:06
@herr-seppia herr-seppia merged commit b06789d into master Jan 15, 2024
3 checks passed
@herr-seppia herr-seppia deleted the fix_step_votes_registry branch January 15, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants