Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transfer-contract: add next_pos contract call #1253

Merged
merged 2 commits into from
Jan 16, 2024
Merged

transfer-contract: add next_pos contract call #1253

merged 2 commits into from
Jan 16, 2024

Conversation

herr-seppia
Copy link
Member

No description provided.

@herr-seppia herr-seppia force-pushed the transfer_last_pos branch 2 times, most recently from ecdc2bb to f0afb9c Compare January 15, 2024 16:57
@herr-seppia herr-seppia marked this pull request as ready for review January 15, 2024 16:59
@Daksh14
Copy link
Contributor

Daksh14 commented Jan 15, 2024

Unit or integration tests should be included too.

Other than that, LGTM

@herr-seppia herr-seppia changed the title transfer-contract: add last_pos contract call transfer-contract: add next_pos contract call Jan 16, 2024
@herr-seppia
Copy link
Member Author

Unit or integration tests should be included too.

You're right.
In the meanwhile I changed last_pos with next_pos to not struggle with Option when no notes are present

ureeves
ureeves reviewed Jan 16, 2024
View reviewed changes
Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about calling this function n_notes (or num_notes, or something similar) as opposed to next_pos? I personally would find it a bit more descriptive.

@herr-seppia herr-seppia requested a review from ureeves January 16, 2024 16:16
ureeves
ureeves approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herr-seppia herr-seppia merged commit 147158f into master Jan 16, 2024
3 checks passed
@herr-seppia herr-seppia deleted the transfer_last_pos branch January 16, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ureeves ureeves ureeves approved these changes

@ZER0 ZER0 Awaiting requested review from ZER0

@Daksh14 Daksh14 Awaiting requested review from Daksh14

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@herr-seppia @Daksh14 @ureeves