Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consensus: Handle messages in emergency mode #1241

Merged
merged 6 commits into from
Jan 12, 2024
Merged

consensus: Handle messages in emergency mode #1241

merged 6 commits into from
Jan 12, 2024

Conversation

goshawk-3
Copy link
Contributor

@goshawk-3 goshawk-3 commented Jan 8, 2024 •
edited
Loading

fixes #1171
fixes #1109

Base automatically changed from fix-1170 to master January 8, 2024 12:34
@goshawk-3 goshawk-3 marked this pull request as ready for review January 9, 2024 09:43
fed-franz
fed-franz requested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@fed-franz fed-franz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are few things to adjust/clarify

consensus/src/execution_ctx.rs Show resolved Hide resolved
consensus/src/execution_ctx.rs Show resolved Hide resolved
consensus/src/execution_ctx.rs Show resolved Hide resolved
consensus/src/validation/step.rs Show resolved Hide resolved
herr-seppia
herr-seppia previously approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall
just some questions

consensus/src/validation/step.rs Outdated Show resolved Hide resolved
consensus/src/execution_ctx.rs Show resolved Hide resolved
consensus/src/config.rs Outdated Show resolved Hide resolved
fed-franz
fed-franz previously approved these changes Jan 11, 2024
View reviewed changes
herr-seppia
herr-seppia approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goshawk-3 goshawk-3 merged commit 57752f2 into master Jan 12, 2024
3 checks passed
@goshawk-3 goshawk-3 deleted the fix-1171 branch January 12, 2024 08:49
@fed-franz fed-franz mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herr-seppia herr-seppia herr-seppia approved these changes

@fed-franz fed-franz Awaiting requested review from fed-franz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

consensus: Emergency Mode Single vote for iteration
3 participants
@goshawk-3 @fed-franz @herr-seppia