Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus: remove iteration from collect_from_past #1239

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

herr-seppia
Copy link
Member

No description provided.

@herr-seppia herr-seppia force-pushed the rm-iteration-collect-past branch 3 times, most recently from 8a39fee to 121618f Compare January 8, 2024 10:35
@herr-seppia herr-seppia changed the base branch from fix-1170 to process-past-ownership January 8, 2024 10:36
@herr-seppia herr-seppia force-pushed the process-past-ownership branch from fefb692 to b44e8e6 Compare January 8, 2024 12:38
fed-franz
fed-franz previously approved these changes Jan 8, 2024
Copy link
Contributor

@fed-franz fed-franz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herr-seppia herr-seppia marked this pull request as draft January 8, 2024 13:30
@herr-seppia herr-seppia force-pushed the process-past-ownership branch from b44e8e6 to 409904e Compare January 8, 2024 14:22
Base automatically changed from process-past-ownership to master January 8, 2024 15:46
@herr-seppia herr-seppia dismissed fed-franz’s stale review January 8, 2024 15:46

The base branch was changed.

@herr-seppia herr-seppia force-pushed the rm-iteration-collect-past branch from 121618f to 87c190a Compare January 15, 2024 16:55
@herr-seppia herr-seppia marked this pull request as ready for review January 15, 2024 17:00
@herr-seppia herr-seppia force-pushed the rm-iteration-collect-past branch from 87c190a to bf89ad1 Compare January 16, 2024 14:15
@herr-seppia herr-seppia force-pushed the rm-iteration-collect-past branch from bf89ad1 to a1ae54b Compare January 16, 2024 16:39
@herr-seppia herr-seppia merged commit 649f9c5 into master Jan 18, 2024
3 checks passed
@herr-seppia herr-seppia deleted the rm-iteration-collect-past branch January 18, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants