-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove fixed fee #1125
Remove fixed fee #1125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice cleanup!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only a few nits in the comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per discussion, tests should be added to verify consistency between receipt.gas_spent and wallet.balance
Apart from that, I've currently RFC due to a regression found with the following manual test:
- Run a local node
- Send a normal transfer with a very low gas (10k point are enough)
- Node is not able to create blocks due to hash mismatch between EST and VST
Tried the same with master
, and transaction is properly discarded by EST and removed from the mempool
See also #1134
d718a94
to
321aed8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, that test is a nice addition. :)
67672b1
to
f301edc
Compare
This also entails the removal of the "fixed fee" per transfer.
This has been addressed, and the fix is present in the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But I still believe that having a fixed fee for transfer would be a benefit for the network. Does it worth to reintroduce it?
We substitute the
spend
function in the transfer contract for aspend_and_execute
function, that also executes the contract call.This fixes a bug where it was impossible to inform a genesis contract about whether they're being called in "management mode" by the VM - leading to sensitive functions being reachable by any contract call.
It also removes the fixed fee per transfer, since it was extremely artificial, and the regular transfer fee, while variable, is not much higher regardless.