Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BLS keys #1102

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Update BLS keys #1102

merged 3 commits into from
Oct 25, 2023

Conversation

herr-seppia
Copy link
Member

@herr-seppia herr-seppia marked this pull request as ready for review October 24, 2023 14:51
HDauven
HDauven approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@HDauven HDauven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

What's the reason we use sha2 instead of sha3 here?

@herr-seppia
Copy link
Member Author

What's the reason we use sha2 instead of sha3 here?

Just to be compliant with the algo used by wallet-cli while exporting the keys

@herr-seppia herr-seppia merged commit 42c9966 into master Oct 25, 2023
3 checks passed
@herr-seppia herr-seppia deleted the update-keys branch October 25, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HDauven HDauven HDauven approved these changes

@goshawk-3 goshawk-3 Awaiting requested review from goshawk-3

@ureeves ureeves Awaiting requested review from ureeves

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot load provisioner keys
2 participants
@herr-seppia @HDauven