Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to clap 4.x #1079

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Migrate to clap 4.x #1079

merged 4 commits into from
Oct 10, 2023

Conversation

herr-seppia
Copy link
Member

@herr-seppia herr-seppia commented Oct 6, 2023 •
edited
Loading

node

  • remove clap dependencies

rusk-recovery

  • update clap to 4.x

rusk

  • update clap to 4.x
  • use clap derive for CLI args

Resolves #778

HDauven
HDauven approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@HDauven HDauven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice abstraction.

@herr-seppia herr-seppia merged commit da2dc96 into master Oct 10, 2023
3 checks passed
@herr-seppia herr-seppia deleted the clap4 branch October 10, 2023 08:10
@herr-seppia herr-seppia mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HDauven HDauven HDauven approved these changes

@Daksh14 Daksh14 Awaiting requested review from Daksh14

@ureeves ureeves Awaiting requested review from ureeves

@goshawk-3 goshawk-3 Awaiting requested review from goshawk-3

@Neotamandua Neotamandua Awaiting requested review from Neotamandua

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate 'Clap' to V4
2 participants
@herr-seppia @HDauven