Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --profile cli argument #1075

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Add --profile cli argument #1075

merged 2 commits into from
Oct 4, 2023

Conversation

herr-seppia
Copy link
Member

@herr-seppia herr-seppia commented Oct 3, 2023

With #1057 the rusk-recovery --profile argument was removed.

This PR partially revert the removal, but still keeps the argument optional.

In the same way, a new --profile arg has been added to rusk too

- Revert the 598891b commit.
- Make `--profile` arg optional
Copy link
Member

@HDauven HDauven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Neotamandua Neotamandua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@herr-seppia herr-seppia merged commit 790b12d into master Oct 4, 2023
3 checks passed
@herr-seppia herr-seppia deleted the add-profile-arg branch October 4, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants