node: change LongLivedService trait

- Add default `initialize` implementation
dusk-network · Aug 2, 2024 · bff23f9 · bff23f9
1 parent 36b8ba6
commit bff23f9
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 28 deletions.
diff --git a/node/src/databroker.rs b/node/src/databroker.rs
@@ -93,15 +93,6 @@ impl DataBrokerSrv {
 impl<N: Network, DB: database::DB, VM: vm::VMExecution>
     LongLivedService<N, DB, VM> for DataBrokerSrv
 {
-    async fn initialize(
-        &mut self,
-        _network: Arc<RwLock<N>>,
-        _db: Arc<RwLock<DB>>,
-        _vm: Arc<RwLock<VM>>,
-    ) -> anyhow::Result<()> {
-        Ok(())
-    }
-
     async fn execute(
         &mut self,
         network: Arc<RwLock<N>>,

diff --git a/node/src/lib.rs b/node/src/lib.rs
@@ -106,12 +106,15 @@ pub trait Network: Send + Sync + 'static {
 pub trait LongLivedService<N: Network, DB: database::DB, VM: vm::VMExecution>:
     Send + Sync
 {
+    #[allow(unused_variables)]
     async fn initialize(
         &mut self,
         network: Arc<RwLock<N>>,
         database: Arc<RwLock<DB>>,
         vm: Arc<RwLock<VM>>,
-    ) -> anyhow::Result<()>;
+    ) -> anyhow::Result<()> {
+        Ok(())
+    }
 
     async fn execute(
         &mut self,

diff --git a/node/src/mempool.rs b/node/src/mempool.rs
@@ -52,15 +52,6 @@ impl Default for MempoolSrv {
 impl<N: Network, DB: database::DB, VM: vm::VMExecution>
     LongLivedService<N, DB, VM> for MempoolSrv
 {
-    async fn initialize(
-        &mut self,
-        _network: Arc<RwLock<N>>,
-        _db: Arc<RwLock<DB>>,
-        _vm: Arc<RwLock<VM>>,
-    ) -> anyhow::Result<()> {
-        Ok(())
-    }
-
     async fn execute(
         &mut self,
         network: Arc<RwLock<N>>,

diff --git a/node/src/telemetry.rs b/node/src/telemetry.rs
@@ -29,15 +29,6 @@ impl<N: Network, DB: database::DB, VM: vm::VMExecution>
         "telemetry"
     }
 
-    async fn initialize(
-        &mut self,
-        _network: Arc<RwLock<N>>,
-        _db: Arc<RwLock<DB>>,
-        _vm: Arc<RwLock<VM>>,
-    ) -> anyhow::Result<()> {
-        Ok(())
-    }
-
     /// Initialize and spawn Prometheus Exporter and Recorder
     async fn execute(
         &mut self,