node: Call preverify(tx) after basic checks pass

dusk-network · Aug 8, 2024 · a9dd36a · a9dd36a
1 parent 22a32de
commit a9dd36a
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/node/src/mempool.rs b/node/src/mempool.rs
@@ -111,11 +111,6 @@ impl MempoolSrv {
         vm: &Arc<RwLock<VM>>,
         tx: &Transaction,
     ) -> Result<(), TxAcceptanceError> {
-        // VM Preverify call
-        if let Err(e) = vm.read().await.preverify(tx) {
-            Err(TxAcceptanceError::VerificationFailed(format!("{e:?}")))?;
-        }
-
         let tx_id = tx.id();
 
         // Perform basic checks on the transaction
@@ -138,6 +133,11 @@ impl MempoolSrv {
             Ok(())
         })?;
 
+        // VM Preverify call
+        if let Err(e) = vm.read().await.preverify(tx) {
+            Err(TxAcceptanceError::VerificationFailed(format!("{e:?}")))?;
+        }
+
         // Try to add the transaction to the mempool
         db.read().await.update(|db| {
             let nullifiers: Vec<_> = tx