Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Default trait implementation for Witness #816

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

moCello
Copy link
Member

@moCello moCello commented Feb 27, 2024

Resolves #815

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.32%. Comparing base (7505e9a) to head (7312fa9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #816      +/-   ##
==========================================
- Coverage   85.34%   85.32%   -0.03%     
==========================================
  Files          57       57              
  Lines        3686     3687       +1     
==========================================
  Hits         3146     3146              
- Misses        540      541       +1     
Files Coverage Δ
src/composer/constraint_system/witness.rs 66.66% <0.00%> (-6.07%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7505e9a...7312fa9. Read the comment docs.

@moCello moCello force-pushed the mocello/815_default_witness branch from 9baa8b7 to 354693e Compare February 27, 2024 16:49
@moCello moCello force-pushed the mocello/815_default_witness branch from 354693e to 7312fa9 Compare February 27, 2024 16:56
@moCello moCello merged commit d40aca9 into master Feb 28, 2024
11 checks passed
@moCello moCello deleted the mocello/815_default_witness branch February 28, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Default trait implementation for Witness
2 participants