Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn Composer trait into a struct #803

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Turn Composer trait into a struct #803

merged 1 commit into from
Dec 21, 2023

Conversation

moCello
Copy link
Member

@moCello moCello commented Dec 21, 2023

Resolves: #802

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (4b3568f) 85.63% compared to head (08dc0f6) 85.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #803      +/-   ##
==========================================
+ Coverage   85.63%   85.66%   +0.03%     
==========================================
  Files          57       57              
  Lines        4128     4095      -33     
==========================================
- Hits         3535     3508      -27     
+ Misses        593      587       -6     
Files Coverage Δ
src/composer/compiler.rs 99.44% <100.00%> (ø)
src/composer/gate.rs 0.00% <ø> (ø)
src/composer/prover.rs 95.54% <100.00%> (ø)
src/composer/verifier.rs 86.00% <100.00%> (ø)
src/constraint_system/constraint.rs 61.01% <ø> (-9.48%) ⬇️
src/proof_system/proof.rs 95.94% <ø> (ø)
src/runtime.rs 21.42% <ø> (+4.76%) ⬆️
tests/append_gate.rs 93.75% <100.00%> (ø)
tests/composer.rs 96.42% <100.00%> (+0.27%) ⬆️
tests/decomposition.rs 87.75% <100.00%> (-4.41%) ⬇️
... and 14 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b3568f...08dc0f6. Read the comment docs.

And rename `Arithmetization` to `Gate`.

Resolves #802
Copy link
Member

@xevisalle xevisalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moCello moCello merged commit 3a18dd1 into master Dec 21, 2023
10 checks passed
@moCello moCello deleted the mocello/802_composer branch December 21, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Composer into a struct
2 participants