Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JubJubScalarMalformed error #785

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Add JubJubScalarMalformed error #785

merged 2 commits into from
Oct 27, 2023

Conversation

HDauven
Copy link
Member

@HDauven HDauven commented Oct 27, 2023

Resolves #784

@HDauven HDauven requested a review from moCello October 27, 2023 12:23
@HDauven HDauven force-pushed the jubjub-malformed-error-784 branch from 2486f7e to fc6ca42 Compare October 27, 2023 12:25
@dusk-network dusk-network deleted a comment from codecov bot Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Merging #785 (cf21a19) into master (e8960ba) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
- Coverage   85.07%   85.05%   -0.03%     
==========================================
  Files          57       57              
  Lines        4047     4047              
==========================================
- Hits         3443     3442       -1     
- Misses        604      605       +1
Files Coverage Δ
src/error.rs 0.00% <ø> (ø)
src/composer.rs 90.57% <0.00%> (ø)

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8960ba...cf21a19. Read the comment docs.

moCello
moCello approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HDauven HDauven force-pushed the jubjub-malformed-error-784 branch from 41e315d to b016dd9 Compare October 27, 2023 13:16
@HDauven HDauven force-pushed the jubjub-malformed-error-784 branch from b016dd9 to cf21a19 Compare October 27, 2023 13:25
@HDauven HDauven merged commit 7b22063 into master Oct 27, 2023
8 checks passed
@HDauven HDauven deleted the jubjub-malformed-error-784 branch October 27, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moCello moCello moCello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add JubJubScalarMalformed error
2 participants
@HDauven @moCello