Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename polynomial to arithmetization #781

Merged
merged 2 commits into from
Oct 25, 2023
Merged

rename polynomial to arithmetization #781

merged 2 commits into from
Oct 25, 2023

Conversation

ashWhiteHat
Copy link
Contributor

close #706

composer::Polynomial and fft::Polynomial are confusing so renamed composer::Polynomial to Arithmetization.
I renamed fft::Polynomial as FftPolynomial to Polynomial accordingly.

I would appreciate it if you could confirm.
Thank you.

@xevisalle xevisalle requested review from moCello and vlopes11 October 19, 2023 09:59
moCello
moCello requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, please also add a CHANGELOG entry

@ashWhiteHat
Copy link
Contributor Author

Hi @moCello
Thank you for the review.
I added changes to CHANGELOG.md.

@ashWhiteHat ashWhiteHat requested a review from moCello October 20, 2023 00:34
moCello
moCello approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moCello moCello merged commit e8960ba into dusk-network:master Oct 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moCello moCello moCello approved these changes

@vlopes11 vlopes11 Awaiting requested review from vlopes11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the Polynomial struct name
2 participants
@ashWhiteHat @moCello