Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI jobs #779

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Update CI jobs #779

merged 1 commit into from
Oct 19, 2023

Conversation

HDauven
Copy link
Member

@HDauven HDauven commented Oct 18, 2023

Replaces some of the jobs with reusable workflows, and others with more modern actions.

Resolves #776
Potentially solves #669 due to the action update, as codecov behaves as expected now.

@HDauven HDauven force-pushed the update-ci branch 6 times, most recently from be5d38f to 48be5f4 Compare October 18, 2023 16:55
@dusk-network dusk-network deleted a comment from codecov bot Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #779 (c0d3470) into master (8f9cf5a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #779   +/-   ##
=======================================
  Coverage   84.02%   84.02%           
=======================================
  Files          57       57           
  Lines        4094     4094           
=======================================
  Hits         3440     3440           
  Misses        654      654           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f9cf5a...c0d3470. Read the comment docs.

Replaces some of the jobs with reusable workflows, and others
with more modern actions.
@HDauven HDauven requested review from Fulviuus and moCello October 18, 2023 20:30
@HDauven HDauven added the area:conf&build tasks related to our configuration or build system (Makefile, Docker, scripts, commands) label Oct 18, 2023
@HDauven HDauven self-assigned this Oct 18, 2023
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HDauven HDauven linked an issue Oct 19, 2023 that may be closed by this pull request
@HDauven HDauven merged commit 9e5e88b into master Oct 19, 2023
8 checks passed
@HDauven HDauven deleted the update-ci branch October 19, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:conf&build tasks related to our configuration or build system (Makefile, Docker, scripts, commands)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve CI workflow Code coverage fails because it takes the wrong commit for master
2 participants