-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement proofs of page inclusion #289
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `Module` now contains an actual `dusk_wasmtime::Module`, as opposed to just some bytes, since it allows us to check for some invariants.
ureeves
force-pushed
the
tree-inclusion-273
branch
from
November 1, 2023 16:09
8020e66
to
2f58949
Compare
Two different trees are created - one for 32-bit and another for 64-bit - and ensure they're properly distinguished.
ureeves
force-pushed
the
tree-inclusion-273
branch
from
November 1, 2023 16:09
2f58949
to
7733fd7
Compare
Introduces `Session::memory_pages`, returning an iterator over a contract's pages, together with an inclusion proof - expressed in a new type `PageOpening`. `PageOpening` leverages `dusk-merkle` to allow for verification that a page is indeed in a state with the given root. Resolves #273
ureeves
requested review from
miloszm,
fed-franz,
HDauven,
moCello,
herr-seppia and
Neotamandua
November 6, 2023 15:20
HDauven
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
miloszm
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
moCello
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
Session::memory_pages
, returning an iterator over a contract's pages, together with an inclusion proof - expressed in a new typePageOpening
.PageOpening
leveragesdusk-merkle
to allow for verification that a page is indeed in a state with the given root.Resolves #273