Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'phoenix-core` to a workspace called phoenix #172

Merged
merged 1 commit into from
May 16, 2024

Conversation

moCello
Copy link
Member

@moCello moCello commented May 16, 2024

Resolves #171

@moCello moCello force-pushed the mocello/171_workspace branch from f4e7696 to 957def4 Compare May 16, 2024 12:02
@xevisalle xevisalle self-requested a review May 16, 2024 12:03
@moCello moCello force-pushed the mocello/171_workspace branch from 957def4 to 1dd3d54 Compare May 16, 2024 12:22
@moCello moCello requested review from HDauven, ZER0 and ureeves May 16, 2024 12:24
Copy link
Member

@xevisalle xevisalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPMGTM

Copy link
Member

@HDauven HDauven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple of small recommendations

circuits/CHANGELOG.md Outdated Show resolved Hide resolved
circuits/Cargo.toml Outdated Show resolved Hide resolved
core/Cargo.toml Outdated Show resolved Hide resolved
core/README.md Outdated Show resolved Hide resolved
@moCello moCello force-pushed the mocello/171_workspace branch from f47eea1 to 163fe82 Compare May 16, 2024 12:40
@moCello moCello force-pushed the mocello/171_workspace branch from 163fe82 to 20be36f Compare May 16, 2024 12:43
@moCello moCello merged commit 7728ed3 into master May 16, 2024
6 checks passed
@moCello moCello deleted the mocello/171_workspace branch May 16, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

turn 'phoenix-core' into a 'phoenix' workspace
3 participants