-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ElGamal cipher #161
Add ElGamal cipher #161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how these aes::encrypt
and elgamal::decrypt
now come together :)
One comment on the naming side: I prefer to name zk_encrypt
-> encrypt_gadget
since we are using that convention across our stack.
And I was wondering why there is only a zk_encrypt
? Are we not decrypting in the circuit?
@marta-belles do you think it makes sense to have a decryption method in-circuit? I didn't implement it cause we don't need it, but I guess it doesn't hurt to have it just in case. |
I can't think of a case that we will prove decryption in-circuit, but there is no harm in having it there for completeness:) |
Resolves: #162