Merge pull request #24 from dusk-network/vlopes11/10-dhke

DHKE should return canonical EC point
dusk-network · Jul 28, 2020 · fcc40f2 · fcc40f2
2 parents 11a1061 + 35edeb1
commit fcc40f2
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/Cargo.toml b/Cargo.toml
@@ -11,7 +11,7 @@ homepage = "https://github.com/dusk-network/jubjub"
 license = "MIT/Apache-2.0"
 name = "dusk-jubjub"
 repository = "https://github.com/dusk-network/jubjub"
-version = "0.3.3"
+version = "0.3.4"
 keywords = ["cryptography", "jubjub", "zk-snarks", "ecc", "elliptic-curve"]
 categories =["algorithms", "cryptography", "science"]
 edition = "2018"

diff --git a/RELEASES.md b/RELEASES.md
@@ -1,3 +1,7 @@
+# 0.3.4
+### Fix
+- Fix `dhke` to return an elliptic curve point instead of scalar.
+
 # 0.3.3
 ### Fix
 - Fix `GENERATOR_NUMS` value and add tests to check it's correct.

diff --git a/src/lib.rs b/src/lib.rs
@@ -1504,7 +1504,6 @@ fn test_serialization_consistency() {
 }
 
 /// Compute a shared secret `secret · public` using DHKE protocol
-pub fn dhke(secret: &Fr, public: &ExtendedPoint) -> Fq {
-    let shared: AffinePoint = public.mul(secret).into();
-    shared.get_y()
+pub fn dhke(secret: &Fr, public: &ExtendedPoint) -> AffinePoint {
+    public.mul(secret).into()
 }