Add initial implentation #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moCello
force-pushed
the
mocello/1_initial_impl
branch
from
153724a to
f7967bd
Compare
xevisalle
approved these changes
Nov 25, 2024
moCello
commented
Nov 25, 2024
src/lib.rs
Outdated
| /// original plaintext. | ||
| /// | ||
| /// ## Return | ||
| /// Returns the `[JubJubExtended]` plaintext. |
There was a problem hiding this comment.
Will fix this:
Suggested change
| /// Returns the `[JubJubExtended]` plaintext. | |
| /// Returns the [`JubJubExtended`] plaintext. |
moCello
commented
Nov 25, 2024
src/lib.rs
Outdated
| /// original plaintext in a gadget that can be used in a plonk-circuit. | ||
| /// | ||
| /// ## Return | ||
| /// Returns the `[WitnessPoint]` plaintext. |
There was a problem hiding this comment.
Will fix this
Suggested change
| /// Returns the `[WitnessPoint]` plaintext. | |
| /// Returns the [`WitnessPoint`] plaintext. |
moCello
commented
Nov 25, 2024
src/lib.rs
Outdated
| /// plaintext [`JubJubExtended`]. | ||
| /// | ||
| /// ## Return | ||
| /// Returns the ciphertext tuple `([JubJubExtended], [JubJubExtended])`. |
There was a problem hiding this comment.
Will fix this
Suggested change
| /// Returns the ciphertext tuple `([JubJubExtended], [JubJubExtended])`. | |
| /// Returns the ciphertext tuple `(JubJubExtended, JubJubExtended)`. |
moCello
force-pushed
the
mocello/1_initial_impl
branch
from
f7967bd to
d185db3
Compare
moCello
force-pushed
the
mocello/1_initial_impl
branch
from
d185db3 to
263c54a
Compare
Neotamandua
reviewed
Nov 25, 2024
README.md
Outdated
Comment on lines
54
to
56
| $$ | ||
| c_2 - c_1 * sk_B = m + PK_B * r - (r * G * sk_B) = m + PK_B * r - PK_B * r = m | ||
| $$ |
There was a problem hiding this comment.
This is not rendering properly on the md (at least for me)
There was a problem hiding this comment.
hmm, you're right, it also doesn't render it on github even though github flavored markdown supposedly supports $$ for math blocks. A ```math block seems to do the trick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1