Propagate message metadata #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goshawk-3
reviewed
Aug 8, 2022
herr-seppia
force-pushed
the
metadata-1452
branch
from
76e9d83 to
49012ac
Compare
Codecov Report
@@ Coverage Diff @@
## master #1453 +/- ##
===========================================
- Coverage 50.51% 40.31% -10.21%
===========================================
Files 145 147 +2
Lines 7544 9650 +2106
===========================================
+ Hits 3811 3890 +79
- Misses 3066 5132 +2066
+ Partials 667 628 -39
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
herr-seppia
force-pushed
the
metadata-1452
branch
from
49012ac to
bbc400e
Compare
- Replace the current `message.Header` bytes with a structured `message.Metadata` - Remove redundant usages of `config.KadcastInitHeader` Resolves #1452
herr-seppia
force-pushed
the
metadata-1452
branch
2 times, most recently
from
a5addb0 to
7aa0f65
Compare
Default transaction's kadcast height cannot be 0. If so, tx will not be repropagated
herr-seppia
force-pushed
the
metadata-1452
branch
from
7aa0f65 to
c6688ac
Compare
goshawk-3
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
message.Headerbytes with a structuredmessage.Metadataconfig.KadcastInitHeaderResolves #1452