-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support both rate limiter and pendingPropagation in mempool #1238
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1238 +/- ##
==========================================
- Coverage 50.51% 47.62% -2.90%
==========================================
Files 145 139 -6
Lines 7544 8508 +964
==========================================
+ Hits 3811 4052 +241
- Misses 3066 3870 +804
+ Partials 667 586 -81
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes requested:
- If my understanding of the rate limiting is correct, we should probably allow an additional configuration parameter to tune transaction burst other than
1
. - Context cancelation leakage should be assessed. It might be that the
m.pendingPropagation
channel would be garbage collected, but this needs to be double checked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixes #1237